[WIP] RBF mesh deformation #2240
Open
+3,089
−1,648
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kursatyurt
reviewed
Mar 14, 2024
Common/include/grid_movement/CRadialBasisFunctionInterpolation.hpp
Outdated
Show resolved
Hide resolved
Common/include/grid_movement/CRadialBasisFunctionInterpolation.hpp
Outdated
Show resolved
Hide resolved
| break; | ||
| case DEFORM_KIND::ELASTIC: | ||
| VolumetricMovement = new CLinearElasticity(geometry, config); | ||
|
|
There was a problem hiding this comment.
I did not see the freeing of the memory of those classes, when and where they were freed.
There was a problem hiding this comment.
If I am not mistaken this is done once CommonFinalize()of CDriverBase is called here:
https://github.com/FvanSteen/SU2/blob/ea3588013abfb5cf2004fcae546d83cffeab349d/SU2_CFD/src/drivers/CDriverBase.cpp#L127-L137
In case of internal boundaries that are allowed to move freely based on the deformation of moving boundaries, these options enable it to do so.
Requires some clean up work
Co-authored-by: Kürşat Yurt <57598663+kursatyurt@users.noreply.github.com>
Removal of void as input parameter and other minor changes Co-authored-by: Kürşat Yurt <57598663+kursatyurt@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Proposed Changes
Give a brief overview of your contribution here in a few sentences.
Related Work
Resolve any issues (bug fix or feature request), note any related PRs, or mention interactions with the work of others, if any.
PR Checklist
Put an X by all that apply. You can fill this out after submitting the PR. If you have any questions, don't hesitate to ask! We want to help. These are a guide for you to know what the reviewers will be looking for in your contribution.
pre-commit run --allto format old commits.