Fix periodic parallel preprocessing #2520
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Proposed Changes
Fixes #2518.
Modify the logic in
CGeometry::PreprocessPeriodicComms()to use unordered sets of point-marker pairs when determining number of points to communicate to each destination rank.When counting points, the old logic just checked that the previous point was not the same as the current point, and when generating the list of points to be communicated, there was no check in place. In some cases, the old logic would lead to a segfault during preprocessing, such as the old result shown below for the isentropic vortex.
Before
After
PR Checklist
pre-commit run --allto format old commits.