Develop #2698
Develop #2698
Conversation
- MUSCL_KAPPA_FLOW 0.5 - Binary restart for SST
* fix * Aachen turbine ... * Aachen turbine - change tolerance
Bumps [actions/upload-artifact](https://github.com/actions/upload-artifact) from 4 to 5. - [Release notes](https://github.com/actions/upload-artifact/releases) - [Commits](actions/upload-artifact@v4...v5) --- updated-dependencies: - dependency-name: actions/upload-artifact dependency-version: '5' dependency-type: direct:production update-type: version-update:semver-major ... Signed-off-by: dependabot[bot] <support@github.com>
…ns/download-artifact-5 Bump actions/download-artifact from 4 to 5
…ns/upload-artifact-5 Bump actions/upload-artifact from 4 to 5
…b/codeql-action-4 Bump github/codeql-action from 3 to 4
…ns/setup-python-6 Bump actions/setup-python from 5 to 6
…r runner names containing 'arm'
* fixe scalar restart, update psi case * reduce y+ warning * Update SU2_CFD/src/solvers/CTurbSolver.cpp Co-authored-by: Cristopher Morales <98025159+Cristopher-Morales@users.noreply.github.com> * fix weakly coupled heat restart * Apply suggestion from @bigfooted * Apply suggestion from @bigfooted * remove unused var * fix mass diffusivity MPI bug * use enthalpy for computing temperature also when energy is off * fix sensible enthalpy * remove temperatureInc * remove unused variable * change viscosity call * fix some regression * fix some regression * nondimensionalize poly-cp * change nondimensionalization of cp and enthalpy * fix polynomial cp * update warning * update easy regression tests * update parallel regressions * update regressions * fix bug in nondimensionalization * update regressions * update regressions * fixing tutorials * fixing tutorials and add relaxation factor * fix typo * Update SU2_CFD/src/solvers/CIncEulerSolver.cpp * Update SU2_CFD/src/solvers/CNSSolver.cpp * Update TestCases/flamelet/04_laminar_premixed_ch4_flame_cht_ad/lam_prem_ch4_cht_ad_fluid.cfg * Update TestCases/flamelet/04_laminar_premixed_ch4_flame_cht_ad/lam_prem_ch4_cht_ad_solid.cfg * Update TestCases/flamelet/04_laminar_premixed_ch4_flame_cht_ad/lam_prem_ch4_cht_ad_fluid.cfg * update some more regressions * update some more regressions * update some more regressions * change regression back --------- Co-authored-by: Cristopher Morales <98025159+Cristopher-Morales@users.noreply.github.com>
* python source term for heat solver
There was a bug in the routine checking the inclusion of the query in the range of the network inputs. When loading multiple networks with the same input and output variables, MLPCpp checks which of the networks has an input range that includes the query. This was done incorrectly, resulting in extrapolation. Now this bug has been fixed in MLPCpp and the submodule tag was updated
* update treatment of reference temperature * update pywrapper testcase
Fix #2546: Implemented ADT-based probe search and batched AllReduce
…ns/checkout-6 Bump actions/checkout from 5 to 6
…b/codeql-action-4 Bump github/codeql-action from 3 to 4
…ns/setup-python-6 Bump actions/setup-python from 5 to 6
…ns/download-artifact-6 Bump actions/download-artifact from 4 to 6
…ns/upload-artifact-5 Bump actions/upload-artifact from 4 to 5
Update year to 2026
Changing version number to 8.4.0
![github-advanced-security[bot]](https://avatars.githubusercontent.com/in/57789?s=60&v=4){kind=small}
| // su2double Enthalpy = V_i[nDim+3]; | ||
| su2double Laminar_Viscosity = V_i[nDim+5]; | ||
| su2double Eddy_Viscosity = V_i[nDim+6]; | ||
| su2double Thermal_Conductivity = V_i[nDim+7]; | ||
| su2double Cp = V_i[nDim+8]; |
Check notice
Code scanning / CodeQL
Commented-out code
Show autofix suggestion
Hide autofix suggestion
Copilot Autofix
AI 10 days ago
To fix the problem, we should eliminate the commented‑out code so that comments only contain explanations or documentation, not disabled statements. Since Energy is not used anywhere in the provided ComputeResidual implementation, the best non‑intrusive fix is to delete the commented‑out declaration entirely, preserving the current behavior.
Concretely, in SU2_CFD/src/numerics/continuous_adjoint/adj_sources.cpp, inside CSourceViscous_AdjFlow::ComputeResidual, remove the line // su2double Energy = Enthalpy - Pressure/Density;. No new variables, methods, or imports are needed, and functionality remains unchanged because the code was already inactive.
| @@ -365,7 +365,6 @@ | ||
| su2double Thermal_Conductivity = V_i[nDim+7]; | ||
| su2double Cp = V_i[nDim+8]; | ||
|
|
||
| // su2double Energy = Enthalpy - Pressure/Density; | ||
| su2double invDensity = 1.0/Density; | ||
| su2double invDensitysq = invDensity*invDensity; | ||
| su2double invDensitycube = invDensitysq*invDensity; |
| su2double Prandtl_Turb = config->GetPrandtl_Turb(); | ||
| su2double mu_tot_1 = Laminar_Viscosity + Eddy_Viscosity; | ||
| su2double mu_tot_2 = Laminar_Viscosity/Prandtl_Lam + Eddy_Viscosity/Prandtl_Turb; | ||
| su2double mu_tot_2 = Thermal_Conductivity/Cp + Eddy_Viscosity/Prandtl_Turb; |
Check notice
Code scanning / CodeQL
Commented-out code
Show autofix suggestion
Hide autofix suggestion
Copilot Autofix
AI 10 days ago
In general, to fix commented-out code, either (1) fully remove it if it is no longer needed, or (2) reinstate it as live code (and use it) if it is actually required. If the intent is pedagogical or documentation, rewrite it as explanatory text rather than syntactically valid but commented-out code.
For this specific issue, the best minimally invasive fix is to delete the commented-out declaration of Gas_Constant on line 375. The variable is not used anywhere in the shown function, and related thermodynamic quantities are already computed without it. Removing this line changes no functionality and resolves the CodeQL warning. No new imports, methods, or definitions are needed; we simply remove the commented-out code line from CSourceViscous_AdjFlow::ComputeResidual in SU2_CFD/src/numerics/continuous_adjoint/adj_sources.cpp.
| @@ -372,7 +372,6 @@ | ||
| su2double Prandtl_Turb = config->GetPrandtl_Turb(); | ||
| su2double mu_tot_1 = Laminar_Viscosity + Eddy_Viscosity; | ||
| su2double mu_tot_2 = Thermal_Conductivity/Cp + Eddy_Viscosity/Prandtl_Turb; | ||
| // su2double Gas_Constant = config->GetGas_ConstantND(); | ||
|
|
||
| /*--- Required gradients of the flow variables, point j ---*/ | ||
|
|
No description provided.