Small fix affecting MPI+MG+RANS #744
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…riable name more clear.
economon
approved these changes
Jul 29, 2019
Member
economon
left a comment
economon
left a comment
There was a problem hiding this comment.
LGTM. Thanks for tracking that bug down @pcarruscag.
I have just added another small fix for communication of neighbors and made the variable name more clear (to lower the odds of a tricky bug like that again).
pcarruscag
commented
Jul 30, 2019
| turb_naca0012_sst_restart_mg.test_iter = 20 | ||
| turb_naca0012_sst_restart_mg.ntest_vals = 5 | ||
| turb_naca0012_sst_restart_mg.test_vals = [-6.437367, -4.558626, 1.231779, -0.007820, 0.081480] #last 5 columns | ||
| turb_naca0012_sst_restart_mg.test_vals = [-6.437400, -4.558626, 1.231779, -0.007820, 0.081480] #last 5 columns |
Member
Author
There was a problem hiding this comment.
This restores the exact value before #652 so we should be ok now.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Proposed Changes
A small typo was causing the eddy viscosity to not be communicated properly.
Thanks @economon for pointing me in the right direction.
PR Checklist