-
Notifications
You must be signed in to change notification settings - Fork 918
WIP General Framework for Scalar Transport Equations #777
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Closed
Closed
Changes from all commits
Commits
Show all changes
18 commits
Select commit
Hold shift + click to select a range
be9bd68
Added scalar file stubs and updated build.
economon 1da355e
CVariable class for scalar transport equations.
economon f190118
Scalar transport numerics.
economon 204f844
First implementation of scalar transport solver.
economon 924f0ed
Added calls to scalar models in iteration_structure.cpp.
economon c32b4f8
Added integration class changes for scalar transport.
economon f3c083b
First working version of passive scalar implementation and simple com…
economon 069d066
New options, MG fix for inlets, etc.
economon 4102c2f
Merge branch 'develop' into feature_scalar
economon 1dbd211
Updating with develop and fixing a couple of memory issues.
economon b490794
Updating the scalar implementation with the develop branch.
economon 6805674
Clean up of scalar framework for PR.
economon 9129a23
More clean up.
economon 8b1fe53
Small changes.
economon ef7730a
Updated the scalar framework to the new contiguous CVariable structur…
economon 7741b76
Adjusting classes so that all turbulent CVariable and CNumerics inher…
economon 048713e
Fixed turbulent variables names to be the scalar names for viscous flux.
economon dde6063
Updating TurbVar -> ScalarVar across turb solver BCs.
economon File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
Large diffs are not rendered by default.
Oops, something went wrong.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
That excludes cases where we might want to run heat and scalar solvers side by side. So is the idea then to have a scalar solver with a (additional) temperature variable or should the weak coupling option be removed?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think that, in the end, it would be great to make the current heat solver a solver for heat conduction in solids alone by removing the weakly coupled option. This will simplify things throughout the code a bit and let us remove some things. After/with this PR, it should be easier to have the heat solver inherit from some of the base scalar classes, as I have done for the turbulence models.