[WIP] pyBeam integration into SU2 as a subproject #902
Conversation
economon
left a comment
economon
left a comment
There was a problem hiding this comment.
Nice contribution, @rsanfer!
I noticed that the changes contain a couple of mesh.su2 files and a binary here or there (restart files, I think). Can you please remove those when you have a moment? We can move them to the TestCases repo like usual, if you think the regressions will be able to run in the normal way.
pcarruscag
left a comment
pcarruscag
left a comment
There was a problem hiding this comment.
Couple of comments and I second moving the mesh and restart files to the TestCase repo
|
This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. If this is still a relevant issue please comment on it to restart the discussion. Thank you for your contributions. |
|
WIP2 |
|
Hello @pcarruscag, I've been following the conversation about #1124 and the possible conflicts with this PR. I wanted to say that, with respect to this specific PR I kept working on a different branch lately (feature_pyBeam_ShapeDesignV2) which, is currently the most advanced version of the project. How to conciliate? Shall we pull from feature_pyBeam_ShapeDesignV2 directly here? One issue of that version is that I had to introduce some changes into the CFD solver to extend to FSI the fixed Cl design feature. I thought the mods where general but that actually broke something within SU2 CFD AD. Best, |
|
There is no conflict because both here and there the files were moved, to SU2_FSI and FSI_tools respectively. I made the final changes Tom and I had requested on this PR because it did not seem like this was going anywhere... But if you are still working on it, well do what you think is best, I don't have time to figure out how to get rid of the duplication. "develop" needs to work as a staging area, if you have a chunk of work that can be merged, without breaking compilation, testcases, or interfering too much with the work of other folks, then it should be merged ASAP to avoid this kind of situation. Anyway, regarding the initial proposed changes this looks good to me. |
There are no dedicated Test and Tutorials tarballs this time. The tarbals from 7.0.7 are used. Signed-off-by: Sergey Torokhov <torokhov-s-a@yandex.ru>
pcarruscag
changed the title
|
This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. If this is still a relevant issue please comment on it to restart the discussion. Thank you for your contributions. |
Proposed Changes
This PR integrates pyBeam, a non-linear open source beam solver, into the SU2 infrastructure as a subproject, and adds support for coupled FSI simulations using SU2's flow solver and pyBeam's structural solver.
Tutorials on how to use the implementation will come soon. At this point, only minor changes to the compilation and the python scripts are required. The impact to the core of the code is minor.
I will be away for a few days, but please go ahead and have a look/comment/find room for improvement in the meantime :) I will reply to your comments as soon as I'm back to office.
I also added a couple of test cases, but I haven't yet found the best way to hook them to our regression test system. I'll definitely look into it before the PR is merged, but due to personal time constraints, it'd be great if this could be integrated for 7.0.3.
Related Work
This work is the result of a collaboration with @RoccoBombardieri and @crauno from the University Carlos III Madrid.
Please refer to a recent paper at EUROGEN 2019 with regards to this work. Full reference will be provided here upon publication in an Springer ECCOMAS book series.
PR Checklist
Put an X by all that apply. You can fill this out after submitting the PR. If you have any questions, don't hesitate to ask! We want to help. These are a guide for you to know what the reviewers will be looking for in your contribution.