Grid deformation and FSI legacy cleanup #919
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pcarruscag
changed the title
5 tasks
cvencro
approved these changes
Apr 6, 2020
Contributor
cvencro
left a comment
cvencro
left a comment
There was a problem hiding this comment.
Thanks for doing this, LGTM
5 tasks
5 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Proposed Changes
@cvencro and I will be cleaning up the legacy FSI and mesh deformation classes.
The final objective is for the role of CVolumetricMovement to be played by CMeshSolver.
This will be done in steps.
First step done, removed the legacy discrete adjoint driver, all associated classes (legacy transfer, and mesh deformation for static FSI) and methods of CSolver and CVariable made obsolete in the process.
Surface deformations are now done via CMeshSolver (instead of grid_deformation) but we kept the settings backwards compatible.
Related Work
Will eventually be merged with #833 contains #914