Fix large mesh #980
Merged
Fix large mesh #980
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…or(iNeigh) to geometry->node[iPoint]->GetnPoint(iNeigh)
…_SU2_Restart_Binary to accomodate very large meshes.
…during restart and paraview file output.
economon
approved these changes
May 11, 2020
Member
economon
left a comment
economon
left a comment
There was a problem hiding this comment.
LGTM, congrats on your first PR @GomerOfDoom !
Let's see if anyone else has comments
|
|
||
| int totalByteSize, byteSize; | ||
| unsigned long totalByteSize; | ||
| int byteSize; |
Member
There was a problem hiding this comment.
while you're at it, I would just move the declaration of these two variables down to wherever they are used (rather than up here at the top)
SU2_CFD/src/solvers/CSolver.cpp
Outdated
| if (geometry->GetGlobal_to_Local_Point(iPoint_Global) > -1) { | ||
| blocklen[counter] = nFields; | ||
| displace[counter] = iPoint_Global*nFields; | ||
| //if (iPoint_Global*nFields > INT_MAX){ |
Member
There was a problem hiding this comment.
Go ahead and remove the commented warning here since it is no longer needed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Proposed Changes
Changes have been made to accomodate very large meshes/data sets.
MPI calls were changed to accomodate values over the limit of INT_MAX, and some standard int variables were changed to unsigned long variables.
Related Work
Addresses problems raised in issue #949
PR Checklist