Skip to content

Conversation

@mheimgartner
Copy link

It goes with su2code/SU2/pull/1332

@pr-triage pr-triage bot added the PR: draft label Aug 12, 2021
@TobiKattmann
Copy link
Contributor

please make this merge into feature_flamelet and watch out for changes in #70 . Best you go there and click the subscribe bell (and dont forget to like and comment...)

@pcarruscag pcarruscag changed the base branch from develop to master April 2, 2022 11:10
@pcarruscag pcarruscag changed the base branch from master to develop April 2, 2022 11:12
@pcarruscag
Copy link
Member

Apologies for the mess but master and develop had diverged and I had to rebase develop to fix it.
It may be easier to cherrypick your changes onto the new develop to fix the conflicts.

@TobiKattmann
Copy link
Contributor

Other than #70, there were added Testcases that go with the code PR. So @bigfooted @Cristopher-Morales , in case someone continues the multi-component stuff it might be worthwhile to set up a new Testcases branch and either cherry-pick the commits as pedro suggests (but hand copying and new commits works as well ;)

@bigfooted
Copy link
Contributor

Thanks! This week we will be ready to run these testcases with the devel+multicomp merge, so we'll tackle this soon I hope.

@pcarruscag pcarruscag changed the base branch from old_develop to develop June 7, 2023 13:29
@bigfooted
Copy link
Contributor

Since we have many new regression tests for species transport implemented by @Cristopher-Morales, I don't think we will need this testcase anymore. I will close it.

@bigfooted bigfooted closed this Jun 8, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

10 participants