Skip to content
This repository has been archived by the owner on Aug 11, 2024. It is now read-only.

Deleting from note detail does not work #941

Closed
gordonbrander opened this issue Oct 18, 2023 · 0 comments · Fixed by #954
Closed

Deleting from note detail does not work #941

gordonbrander opened this issue Oct 18, 2023 · 0 comments · Fixed by #954
Assignees
@gordonbrander @bfollington
Labels
Bug Something isn't working

Comments

@gordonbrander
Copy link
Collaborator

Steps to reproduce

  • Create a note
  • Save it
  • Tap omnibox
  • Tap delete

What happens: note is not deleted.

What should happen: note is deleted.

We're probably failing to send up the right notification.
@gordonbrander gordonbrander added the Bug Something isn't working label Oct 18, 2023
@gordonbrander gordonbrander moved this from 🏔️ Icebox to 📚 Todo in Subconscious + Noosphere Oct 18, 2023
@gordonbrander gordonbrander mentioned this issue Oct 19, 2023
Merged
21 tasks
@gordonbrander gordonbrander moved this from 📚 Todo to 🧑‍🌾 In Progress in Subconscious + Noosphere Oct 21, 2023
bfollington added a commit that referenced this issue Oct 24, 2023
@gordonbrander @bfollington
Fix delete note from detail view (#954)
36e4552 
Fixes #941

- [x] Fix Notebook tab
    - [x] Fix deletion
    - [x] Add tests
- [x] Fix Feed tab
    - [x] Fix deletion
    - [x] Add tests
- [x] Fix Profile tab
    - [x] Fix deletion
    - [x] Add tests

QA:

- [x] Notebook tab
    - [x] Check delete
    - [x] Check rename
    - [x] Check change audience
- [x] Feed tab
    - [x] Check delete
    - [x] Check rename
    - [x] Check change audience
- [x] Profile tab
    - [x] Check delete
    - [x] Check rename
    - [x] Check change audience

---------

Co-authored-by: Ben Follington <5009316+bfollington@users.noreply.github.com>
@github-project-automation github-project-automation bot moved this from 🧑‍🌾 In Progress to 🌱 Done in Subconscious + Noosphere Oct 24, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees

@gordonbrander gordonbrander

@bfollington bfollington

Labels
Bug Something isn't working
Projects
Subconscious + Noosphere
Status: 🌱 Done
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Fix delete note from detail view subconsciousnetwork/subconscious
2 participants
@gordonbrander @bfollington