Improve deck loading state #1055
Conversation
bfollington
force-pushed
the
2024-01-05-deck-loading-state
branch
from
b4d34a0 to
5dea710
Compare
bfollington
changed the base branch from
main
to
2023-12-15-intertab-notificiations
| } | ||
| .padding(DeckTheme.cardPadding) | ||
| .foregroundStyle(highlight) | ||
| .font(.subheadline) | ||
| .background(Color.brandMarkPink.opacity(0.025).blendMode(.plusLighter)) |
There was a problem hiding this comment.
Optional: slightly tint the header of prompt cards
There was a problem hiding this comment.
Are we lightening the header, or darkening the body?
| // Is the excerpt shorter than the full body of the entry? | ||
| let isTruncated: Bool |
There was a problem hiding this comment.
We no longer need to store this on the model if we truncate based on rendered size instead.
There was a problem hiding this comment.
I think we may want to keep this field. I suspect there will be cases where we want to display "read more", or where the gradient treatment may not be ideal.
Not a strong opinion though.
There was a problem hiding this comment.
I think we'd be better off determining if the text is truncated in a given view which we can actually do with the gradient truncation helper I built - we can definitely explore a "show more..." on top of the gradient cutoff.
There's some nuance around whitespace and empty blocks that made the old approach (checking string length in the DB query) mismatch with user expectations in the UI - even if we don't use gradients everywhere I'd personally rather count pixels than characters.
| } | ||
| .padding(DeckTheme.cardPadding) | ||
| .foregroundStyle(highlight) | ||
| .font(.subheadline) | ||
| .background(Color.brandMarkPink.opacity(0.025).blendMode(.plusLighter)) |
There was a problem hiding this comment.
Are we lightening the header, or darkening the body?
xcode/Subconscious/Shared/Components/Deck/ShuffleProgressView.swift
Outdated
Show resolved
Hide resolved
| // Is the excerpt shorter than the full body of the entry? | ||
| let isTruncated: Bool |
There was a problem hiding this comment.
I think we may want to keep this field. I suspect there will be cases where we want to display "read more", or where the gradient treatment may not be ideal.
Not a strong opinion though.
bfollington
force-pushed
the
2024-01-05-deck-loading-state
branch
from
c676614 to
9c2cad5
Compare
bfollington
changed the base branch from
2023-12-15-intertab-notificiations
to
main
Fixes #1052
Fixes #1053
Fixes #1054
Fixes #1024
Screen.Recording.2024-01-05.at.4.21.29.pm.mov