This repository has been archived by the owner on Aug 11, 2024. It is now read-only.
Tap tab button again to scroll to top #1070
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bfollington
force-pushed
the
2024-01-15-scroll-to-top
branch
from
a536e4f to
dd33b38
Compare
bfollington
commented
Jan 15, 2024
Comment on lines
+286
to
+288
| ForEach(deck.indices, id: \.self) { index in | ||
| let card = deck[index] | ||
|
|
There was a problem hiding this comment.
Apparently there are problems with using enumerated() this way that can result in BAD_ACCESS errors, see: https://stackoverflow.com/a/63145650
Using indices is apparently safer and seems equally readable.
gordonbrander
suggested changes
Jan 16, 2024
| @@ -35,6 +37,7 @@ struct EntryListView: View { | |||
| onLink: onLink | |||
| ) | |||
| } | |||
| .id(idx) | |||
There was a problem hiding this comment.
This is likely to cause issues, as ids are meant to be stable identifiers tied to records. If the record changed but had same index, or if the same record changed index, we might see view invalidation bugs.
Should replace with a stable record ID of some sort.
There was a problem hiding this comment.
Good note, I've ditched this approach and inserted an EmptyView with a stable .id() at the top instead. This is easier to read as well imo, so win-win.
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #991
Pretty simple, using
ScrollReaderViewfor iOS 16 support but we could clean this up a little using the newer iOS 17 APIs down the line.Screen.Recording.2024-01-15.at.4.34.17.pm.mov
Screen.Recording.2024-01-15.at.6.31.00.pm.mov