"Quote in new note" action #1071
Conversation
bfollington
force-pushed
the
2024-01-15-quote-note
branch
from
5a09c52 to
396e7cc
Compare
bfollington
force-pushed
the
2024-01-15-quote-note
branch
from
396e7cc to
8d043ae
Compare
| case let .requestQuoteInNewDetail(address): | ||
| return .pushDetail( | ||
| .editor( | ||
| MemoEditorDetailDescription( | ||
| fallback: "\(address.markup)\n\n" | ||
| ) | ||
| ) | ||
| ) |
There was a problem hiding this comment.
This results in an untitled editor, preloaded with the link and the cursor autofocused in a new block.
There is one UX rough edge, if you back out of the new editor this opens, then the app will automatically save the note... which creates a "garbage" note. Perhaps we should have some clever logic that never saves a note unless it contains something other than / in addition to a single slashlink?
There was a problem hiding this comment.
I think this is fine?
| "Quote in new note", | ||
| systemImage: "quote.opening" |
There was a problem hiding this comment.
I welcome discussion on the best wording and icon for this action.
To me "linking" is inserting a slashlink into an existing note and "quoting" is creating a new note that references / reflects on another note (using linking).
|
Clipping might be another word. I’m clipping it into my own notebook. (This looks good!) |
There was a problem hiding this comment.
LGTM.
My one UX feedback is that I think it might be nicer to place the cursor above the link, with the link on it's own "paragraph" below? I'm imagining what this will look like with transcludes support, and by analogy to quote tweet, you probably want your thoughts above the transcluded content, not below it.
| case let .requestQuoteInNewDetail(address): | ||
| return .pushDetail( | ||
| .editor( | ||
| MemoEditorDetailDescription( | ||
| fallback: "\(address.markup)\n\n" | ||
| ) | ||
| ) | ||
| ) |
There was a problem hiding this comment.
I think this is fine?
| "Quote in new note", | ||
| systemImage: "quote.opening" |
I implemented this and I think it is better, going to run with putting the cursor ahead of the quoted content. |
Fixes #871
Screen.Recording.2024-01-15.at.6.13.26.pm.mov