This repository has been archived by the owner on Aug 11, 2024. It is now read-only.
Profile reskin to match Deck and Notebook #1076
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The more conservative version:
|
gordonbrander
approved these changes
Jan 24, 2024
| @@ -11,7 +11,7 @@ import SwiftUI | |||
| struct EllipsisLabelView: View { | |||
| var body: some View { | |||
| Image(systemName: "ellipsis") | |||
| .frame(width: AppTheme.minTouchSize + AppTheme.padding, height: AppTheme.minTouchSize + AppTheme.unit2) | |||
| .frame(width: AppTheme.minTouchSize, height: AppTheme.minTouchSize) | |||
There was a problem hiding this comment.
yep, I changed the layout of these cards
bfollington
force-pushed
the
2024-01-23-app-skin-profile
branch
from
3a33d8f to
823c30b
Compare
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #1062
After much deliberation, I decided I actually do kinda like the full gradient experience on the profile.
I can see the argument for leaving the header with a solid colour background though (see the comment below).