This repository has been archived by the owner on Aug 11, 2024. It is now read-only.
Fix: tapping links to drafts could (erroneously) open the viewer instead of the editor #1079
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bfollington
commented
Jan 26, 2024
| // Is this address ours? Trim off the peer | ||
| guard did != ourIdentity else { |
There was a problem hiding this comment.
I thought this was clearer but obviously not an essential change
gordonbrander
approved these changes
Jan 26, 2024
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Our
findBestLinkfunction was not consideringDid.localas a possibility. Updated the code + tests to cover these cases.I found this in-app in two places: