This repository has been archived by the owner on Aug 11, 2024. It is now read-only.
Make "Quote" action available from everywhere #1080
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
gordonbrander
approved these changes
Jan 26, 2024
| @@ -14,6 +14,7 @@ struct EntryListView: View { | |||
| var onEntryDelete: (Slashlink) -> Void | |||
| var onRefresh: () -> Void | |||
| var onLink: (EntryLink) -> Void | |||
| var onQuote: (Slashlink) -> Void | |||
There was a problem hiding this comment.
If you have a procedure with ten parameters, you probably missed some. (Alan Perlis https://www.cs.yale.edu/homes/perlis-alan/quotes.html)
Noting for future: if we feel tempted to additional callbacks > 5, perhaps we should switch to domain-specific actions and use a ViewStore.
No action requested. Doing the minimal thing is the right thing for this PR. Just noting for future.
| var onSwipeAbandoned: () -> Void | ||
| var onCardTapped: (CardModel) -> Void | ||
| var onLink: (EntryLink) -> Void | ||
| var notify: (CardNotification) -> Void |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add a
.contextMenuto all the major views to allow Quoting from everywhere.