Skip to content
This repository has been archived by the owner on Aug 11, 2024. It is now read-only.

Allow background to show through in empty view #1082

Merged
merged 1 commit into from
Jan 26, 2024
Merged

Allow background to show through in empty view #1082

merged 1 commit into from
Jan 26, 2024

Conversation

bfollington
Copy link
Collaborator

@bfollington bfollington commented Jan 26, 2024 •
edited
Loading

Fixes a small visual bug

Before:
Simulator Screenshot - iPhone 15 Pro - 2024-01-26 at 18 18 02

After:
Simulator Screenshot - iPhone 15 Pro - 2024-01-26 at 18 15 31

@bfollington bfollington marked this pull request as ready for review January 26, 2024 08:19
gordonbrander
gordonbrander approved these changes Jan 26, 2024
View reviewed changes
Copy link
Collaborator

@gordonbrander gordonbrander left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

Request a follow-up where we vertically center these views if possible.

@gordonbrander gordonbrander merged commit b50cef2 into main Jan 26, 2024
2 checks passed
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@gordonbrander gordonbrander gordonbrander approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@bfollington @gordonbrander