This repository has been archived by the owner on Aug 11, 2024. It is now read-only.
Re-check gateway provisioning status if sync fails but we DO have a gateway ID #1094
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bfollington
added a commit
that referenced
this pull request
Feb 12, 2024
The fix I implemented in #1094 works but it's triggered in scenarios it shouldn't be. There's no ill effect of running this too often but I'd rather be precise.
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We ran into an issue where some gateways failed to come online in production and we timed out waiting. We've fixed the backend issue since. The scenario is recoverable by a user opening their gateway settings and hitting the "Check Provisioning Status" button but we can try to auto-detect and resolve the issue too.
If a sync fails but we do have a gateway ID then it means provisioning must have timed out in the past.
In the MTG future the provisioning time should drop to near-instant hopefully making this even less of an issue.
@gordonbrander can you think of a better condition to detect this situation? The user has redeemed an invite code for a gateway but they haven't received the gateway URL yet. It's still going to be set to
127.0.0.1:4443for anyone hit by this.