This repository has been archived by the owner on Aug 11, 2024. It is now read-only.
-
Notifications
You must be signed in to change notification settings - Fork 0
Add, remove and render likes in list views #1113
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bfollington
commented
Feb 13, 2024
xcode/Subconscious/Shared/Components/Common/EntryList/EntryListView.swift
Show resolved
Hide resolved
bfollington
commented
Feb 13, 2024
bfollington
commented
Feb 13, 2024
gordonbrander
approved these changes
Feb 13, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
xcode/Subconscious/Shared/Components/Common/EntryList/EntryListView.swift
Show resolved
Hide resolved
bfollington
force-pushed
the
2024-02-07-user-likes
branch
from
February 14, 2024 05:12
f5a1af2
to
d980fc1
Compare
bfollington
force-pushed
the
2024-02-13-user-likes-context-menu
branch
2 times, most recently
from
February 14, 2024 05:33
dde4c8f
to
c901d07
Compare
bfollington
force-pushed
the
2024-02-13-user-likes-context-menu
branch
from
February 14, 2024 05:35
c901d07
to
1a6ec84
Compare
bfollington
force-pushed
the
2024-02-13-user-likes-context-menu
branch
from
February 14, 2024 05:37
1a6ec84
to
e6780fa
Compare
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Follow on from #1106
Introduces:
EntryNotification
abstraction to encode the core set of actions that can be taken on a noteDemo
Screen.Recording.2024-02-13.at.12.19.38.pm.mov