Skip to content
This repository has been archived by the owner on Aug 11, 2024. It is now read-only.

Implement "comments" under notes #1114

Merged
merged 6 commits into from
Feb 14, 2024
Merged

Implement "comments" under notes #1114

merged 6 commits into from
Feb 14, 2024

Conversation

bfollington
Copy link
Collaborator

@bfollington bfollington commented Feb 13, 2024

Fixes #1085

  • Implement deterministic hash for color across executions
  • Add comments to editor and viewer
  • Tapping a comment will open a new editor instance preloaded with the comment + address

Copy link
Collaborator

@gordonbrander gordonbrander left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

xcode/Subconscious/Shared/Components/CommentsView.swift Outdated Show resolved Hide resolved
@bfollington bfollington merged commit 8f62533 into main Feb 14, 2024
1 check passed
bfollington added a commit that referenced this pull request Feb 21, 2024
Note colors can change between app restarts. Apparently I messed this up
again even after trying to fix it in
#1114

The mistake was subtle, so I'll give myself a pass.
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

AI Comments: I want to reflect on my notes
2 participants