This repository has been archived by the owner on Aug 11, 2024. It is now read-only.
Implement peer discovery #1117
Merged
Implement peer discovery #1117
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bfollington
commented
Feb 20, 2024
Comment on lines
326
to
333
| case let .requestFollowSuggestion(neighbor): | ||
| return update( | ||
| state: state, | ||
| actions: [ | ||
| .form(.didField(.reset)), | ||
| .form(.petnameField(.reset)), | ||
| .form(.didField(.setValue(input: neighbor.identity.description))), | ||
| .form(.petnameField(.setValue(input: neighbor.name.description))) | ||
| ], | ||
| environment: environment | ||
| ) | ||
| } |
There was a problem hiding this comment.
Pre-populate the Add User form with the best name + DID
bfollington
commented
Feb 20, 2024
| @@ -102,6 +102,7 @@ struct NotebookNavigationView: View { | |||
| } | |||
| } | |||
| } | |||
| .ignoresSafeArea(.keyboard, edges: .bottom) | |||
There was a problem hiding this comment.
An attempt to fix the strange cutoff BG issue we've seen.
gordonbrander
suggested changes
Feb 20, 2024
There was a problem hiding this comment.
High-level design feedback:
- Tapping follow button on discover tab should show toggle follow/unfollow instead of disappearing user you followed.
- Allows undoing accidental follows
- Does not need to show up next time you load the view
- "Follow a user" suggestions should show same view as discover.
- Don't show DID. Too intimidating. We only show DID as a last resort when scanning or manually entering.
There was a problem hiding this comment.
Sounds good to me, I think there's room for visual improvement on the DiscoverUserView component in general but I didn't want to overcook the first pass.
xcode/Subconscious/Shared/Components/Common/Profile/Sheets/FollowNewUserFormSheet.swift
Show resolved
Hide resolved
Also fetch all following peers when listing neighbors
Also show PFPs
bfollington
force-pushed
the
2024-02-16-peer-discovery
branch
from
e0f62c2 to
1aae79d
Compare
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #1084
We need to consider that neighbors won't be indexed retroactively unless we choose to re-index from sphere creation.
Changes
neighborsScreen.Recording.2024-02-20.at.2.38.43.pm.mov