This repository has been archived by the owner on Aug 11, 2024. It is now read-only.
Manage cache validation by comparing version CID #869
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Avoids having to manually invalidate the cache
gordonbrander
suggested changes
Aug 11, 2023
gordonbrander
approved these changes
Aug 18, 2023
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #866
Instead of trying to manually invalidate the cache we can simply store the version (
Cid) as a cache key. Assuming my Noosphere fundamentals are correct, we should never observe a change in address books or user profiles without out own sphere version changing - incredibly convenient.I removed any references to manual cache invalidation since we're using this method in the only two in-memory caches that exist so far.