This repository has been archived by the owner on Aug 11, 2024. It is now read-only.
Retrieve sphere ID from UserDefaults and run recovery check earlier #909
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
We should have been running recovery check against the sphere identity stored in UserDefaults. This is available immediately, so we should just go ahead and start recovery check at .start.
|
Playtested recovery on simulator successfully. Steps:
|
bfollington
reviewed
Sep 28, 2023
Comment on lines
+2456
to
+2461
| // Get any existing sphere identity stored in UserDefaults | ||
| // If none, it's the first run, nothing to recover | ||
| guard let userDefaultsIdentity = AppDefaults.standard.sphereIdentity? | ||
| .toDid() else { | ||
| return AppAction.presentRecoveryMode(false) | ||
| } |
There was a problem hiding this comment.
Check the persisted DID first, if there isn't one we should skip recovery mode.
Tested on Simulator.
bfollington
approved these changes
Sep 28, 2023
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Previously, we were reading the known sphere identity from the SQLite database. This is suboptimal for a couple reasons:
AppDefaults.standard.sphereIdentity(UserDefaults)This PR makes the following changes:
AppDefaults.standard.sphereIdentity.start)Additionally, I added some logs to
NoosphereServiceto make it clearer when we experience a cache miss due to failure to construct sphere.