This repository has been archived by the owner on Aug 11, 2024. It is now read-only.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR updates search view to use a ViewStore. In my playtesting, this significantly improves the perceived perf of type-ahead suggestions.
Why? I suspect this may have something to do with the way inputs work in SwiftUI. Perhaps the binding-style closer access that goes all the way up to store allows the input field to render text BEFORE the search view is invalidated by the parent.
Background:
CustomStringConvertible
forSearchAction
. This wasn't the bottleneck, but I kept it anyway, because IMO its probably a good idea not to serialize and log all suggestions at every keystroke.