⏱ Allow copying of TOTP with a keyboard shortcut and button

subdavis · Jul 29, 2018 · 352f1e5 · 352f1e5
1 parent 4a4b478
commit 352f1e5
Show file tree

Hide file tree

Showing 2 changed files with 12 additions and 8 deletions.
diff --git a/services/unlockedState.js b/services/unlockedState.js
@@ -150,10 +150,16 @@ function UnlockedState($router, keepassReference, protectedMemory, settings, not
 			return; //listener can get registered multiple times
 		}
 
-		var textToPutOnClipboard = getAttribute(copyEntry, copyPart);
-		var fieldName = copyPart.charAt(0).toUpperCase() + copyPart.slice(1); // https://stackoverflow.com/a/1026087
-		copyEntry = null;
-		copyPart = null;
+		let fieldName, textToPutOnClipboard;
+		if (copyPart === 'userName' || copyPart === 'password') {
+            textToPutOnClipboard = getAttribute(copyEntry, copyPart);
+            fieldName = copyPart.charAt(0).toUpperCase() + copyPart.slice(1); // https://stackoverflow.com/a/1026087
+		} else {
+			fieldName = copyPart;
+			textToPutOnClipboard = copyEntry;
+		}
+        copyEntry = null;
+        copyPart = null;
 		e.clipboardData.setData('text/plain', textToPutOnClipboard);
 		e.preventDefault();
 

diff --git a/src/components/EntryListItem.vue b/src/components/EntryListItem.vue
@@ -62,10 +62,7 @@
               otp_value: "",
 			  keyHandler: e => {
                   if ((e.ctrlKey || e.metaKey) && e.key == "/" && !e.altKey && !e.shiftKey)  {
-                      copyPlain = this.otp_value;
-                      document.execCommand('copy')
-					  copyPlain = undefined;
-                      e.stopPropagation
+                      this.copyOtp(e);
                   }
 			  }
           }
@@ -100,6 +97,7 @@
             },
             copyOtp(e) {
 			    e.stopPropagation()
+				this.unlockedState.copyTotp(this.otp_value);
 			},
             parseUrl(url) {
                 url = url.indexOf('http') < 0 ? 'http://' + url : url