Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Hacken 2022-11-25 Low #7] Missing Zero Address Validation #42

Closed
zhongfu opened this issue Dec 1, 2022 · 1 comment · Fixed by #49
Closed

[Hacken 2022-11-25 Low #7] Missing Zero Address Validation #42

zhongfu opened this issue Dec 1, 2022 · 1 comment · Fixed by #49
Labels
sev:p3 Low sev type:enhancement Good-to-have features or fixes
Milestone
Hacken Audit 2022...

Comments

@zhongfu
Copy link
Contributor

zhongfu commented Dec 1, 2022

Address parameters are used without checking against the possibility of being 0x0.

This can lead to unwanted external calls to 0x0.

Paths

./src/Funnel.sol : initialize()
./src/FunnelFactory.sol : constructor(), deployFunnelForToken()

Recommendation

Implement zero address validations.

Status

New
@zhongfu zhongfu added type:enhancement Good-to-have features or fixes sev:p3 Low sev labels Dec 1, 2022
@zhongfu zhongfu added this to the Hacken Audit 2022-11-25 milestone Dec 1, 2022
edison0xyz added a commit that referenced this issue Dec 1, 2022
@edison0xyz
fix: zero address validation and make functions external. Closes #42 c…
3201533 
…loses #45
@zhongfu
Copy link
Contributor Author

zhongfu commented Dec 3, 2022

for FunnelFactory.deployFunnelForToken(): we already check for a non-zero code length, plus there's still going to be a call to Funnel.initialize(address(0)) which will now fail (since 3201533)

@zlace0x zlace0x linked a pull request Dec 5, 2022 that will close this issue
Fix/audits #49
Merged
@zlace0x zlace0x closed this as completed in 8853294 Dec 8, 2022
zlace0x added a commit that referenced this issue Dec 12, 2022
@zlace0x @edison0xyz
Fix/audit 2 (#58)
18a5e7f 
* fix: resolves #48 resolves 45 resolves #44 resolves #41 resolves #38

* fix: closes #34

* fix: zero address validation and make functions external. Closes #42 closes #45

* fixed pragma. closes #36

* fix as 0.8.17

* fix: remove solmate

* refactor: PR comments
- reorder imports, fix qoutes
- removed virtual for _checkOn* functions
- added virtual to supportsInterface
- fix compiler version to 0.8.17

* fix: addresses #32, allowance() amount should reflect transferable amounts for transferFrom() and transfer()

* fix: comment contradition #43

* wip: added overflow test cases according to #30, identified area of overflow

* fix: potential fix for #30

* refactor: adhere to checks-effects-interaction pattern #35

* fix: make allowance() external #45

* fix: dropped virtual from permit, permitRenewable #44

* refactor: added require reason

* chore: added gas reports

* fix: solidity compiler for deploy script

* Chore/natspec (#53)

* style: grouped functions

* forge install: openzeppelin-contracts

* chore: updates to lib

* chore: natspec comments for contracts

* chore: closes #39 and #40

* chore: removed unused solmate

* refactor: moved saturatingAdd to mathUtil

* chore: cleanup

* Apply suggestions from code review

Co-authored-by: zlace0x <81418809+zlace0x@users.noreply.github.com>

* fix: resolve some comments

* doc: generated docs under doc/

* chore: cleanups on comments

* style: use custom errors instead (#56)

* style: use custom errors instead

* fix: structured files for custom errors

* style: change INITIAL values to upper-case

* Update src/Funnel.sol

Co-authored-by: zlace0x <81418809+zlace0x@users.noreply.github.com>

Co-authored-by: Edison <6057323+edison0x@users.noreply.github.com>
Co-authored-by: zlace0x <81418809+zlace0x@users.noreply.github.com>

* chore: fix comments slashes

* fix: apply linter version changes

Co-authored-by: Edison <6057323+edison0x@users.noreply.github.com>
Co-authored-by: zlace0x <zlace0x@gmail.com>
Co-authored-by: zlace0x <81418809+zlace0x@users.noreply.github.com>

Co-authored-by: Edison <6057323+edison0x@users.noreply.github.com>
Co-authored-by: Edison <6057323+edison0xyz@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
sev:p3 Low sev type:enhancement Good-to-have features or fixes
Projects
None yet
Milestone
Hacken Audit 2022-11-25
Development

Successfully merging a pull request may close this issue.

Fix/audits suberra/funnel-contracts
1 participant
@zhongfu