Add list of strings output adapter and update providers to handle the new attribute #47
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
one test but otherwise lgtm~ |
… out why the endpoint is returning a 500
|
🔥 🚀 |
|
👍 |
AndrewBKang
approved these changes
Jul 26, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Added a new output adapter to support returning a list of strings from a prompt.
Needed to add handling for the
items.typeattribute to the 3 providers. Thatformat_propertiesmethod is starting to get messy. I suspect the next few output adapters on the issues list will help us figure out a better way of handling those attributes on the providers end without having to add something new each time we create a new output adapter.Also updated the Gemini provider to use function calling because the previous XML style function calling was looking like it would be too much work to support parsing arrays in its responses...but in doing so, it screwed up the other tests and now gemini won't call functions correctly for the single_string adapter 🤦
Going to think on what to do for a bit but wanted to get this up for now...may need to fix #43 to get gemini working reliably again...