Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

C (and other languages?) mode hint matching is super fragile #2759

Closed
Grazfather opened this issue Mar 20, 2021 · 1 comment · Fixed by #2760
Closed

C (and other languages?) mode hint matching is super fragile #2759

Grazfather opened this issue Mar 20, 2021 · 1 comment · Fixed by #2760
Labels
T: enhancement Improvement of existing language features

Comments

@Grazfather
Copy link

Grazfather commented Mar 20, 2021 •
edited
Loading

If you have a C file that doesn't have a C extension, sublime can still match it with an emacs-style mode hint.

It uses a regex here: https://github.com/sublimehq/Packages/blob/master/C%2B%2B/C.sublime-syntax#L8

first_line_match: "-[*]-( Mode:)? C -[*]-"

This is super fragile, and in fact is incorrect according to the emacs docs

Mode should be lower case, C could probably be lower case, and it's missing the ;, plus extra stuff after.

This might work better: (?i)-[*]- *(mode:)? *(c) *;?.*-[*]-, though I don't know the flavour of regex used here

// -*- mode: C -*-
#include <io.h>

int main() {
        printf("hello);
}

I don't use sublime, but use something that uses its syntax files (bat)
tmux

Now I don't know why you'd write C files that don't have a .c or .cc extension, I was just made aware of this when trying to figure out why another script wasn't highlighting. It might be worth finding the languages where a -[*]- regex is used and fix them up.
@Grazfather Grazfather mentioned this issue Mar 20, 2021
Closed
deathaxe added a commit to deathaxe/sublime-packages that referenced this issue Mar 21, 2021
@deathaxe
[Common] Add or update emacs mode patterns
3708700 
Fixes sublimehq#2759

This commit...

1. sorts main header keys according to sublimehq#2430
2. adds or update `first_line_match` patterns to all appropriate syntax
   definitions in order to support emacs mode tags.

   Examples:

   // -*-c-*-
   // -*- c -*-
   // -*- mode: c -*-
   // -*- mode: c++; -*-
@deathaxe deathaxe mentioned this issue Mar 21, 2021
Merged
deathaxe added a commit to deathaxe/sublime-packages that referenced this issue Mar 21, 2021
@deathaxe
[Common] Add or update emacs mode patterns
aaec85e 
Fixes sublimehq#2759

This commit...

1. sorts main header keys according to sublimehq#2430
2. adds or update `first_line_match` patterns to all appropriate syntax
   definitions in order to support emacs mode tags.

   Examples:

   // -*-c-*-
   // -*- c -*-
   // -*- mode: c -*-
   // -*- mode: c++; -*-
deathaxe added a commit to deathaxe/sublime-packages that referenced this issue Mar 21, 2021
@deathaxe
[Common] Add or update emacs mode patterns
2597f31 
Fixes sublimehq#2759

This commit...

1. sorts main header keys according to sublimehq#2430
2. adds or update `first_line_match` patterns to all appropriate syntax
   definitions in order to support emacs mode tags.

   Examples:

   // -*-c-*-
   // -*- c -*-
   // -*- mode: c -*-
   // -*- mode: c++; -*-
@deathaxe deathaxe mentioned this issue Jun 3, 2021
Closed
@deathaxe deathaxe added the T: enhancement Improvement of existing language features label Aug 19, 2021
deathaxe added a commit that referenced this issue Oct 28, 2021
@deathaxe
[Common] Add or update emacs mode patterns (#2760)
3629e8b 
* [Common] Add or update emacs mode patterns

Fixes #2759

This commit...

1. sorts main header keys according to #2430
2. adds or update `first_line_match` patterns to all appropriate syntax
   definitions in order to support emacs mode tags.

   Examples:

   // -*-c-*-
   // -*- c -*-
   // -*- mode: c -*-
   // -*- mode: c++; -*-

* [ActionScript] Fix first line pattern

* [ASP] Fix first line pattern

Moves `-*- asp -*-` to HTML (ASP).sublime-syntax

* [JSP] Add missing first line pattern

* [Java] Revert first line pattern

JSP is html like syntax and probably doesn't need or never sees such
mode comment.

* [ASP] Revert first line pattern

HTML (ASP) won't probably see any such comment, thus removing it.

* [All] Allow anything in front of emacs mode tag comments

Sync with PR #2862

* [Haskell] Add shebang to first_line_match

* [Lua] Add shebang to first_line_match

* [ShellScript] Add DASH shebang

* [PHP] Add minor version support in shebang

Syncs modification from #2915 to add support for
php executables such as

    php
    php7
    php71
    php7.1
    php7.1.3

to `first_line_match`'s shebang/editorconfig pattern.

* [Batch File] Add "@echo on" to first_line_match
@Grazfather
Copy link
Author

Awesome!

mitranim pushed a commit to mitranim/Packages that referenced this issue Mar 25, 2022
@deathaxe @mitranim
[Common] Add or update emacs mode patterns (sublimehq#2760)
cfc60a9 
* [Common] Add or update emacs mode patterns

Fixes sublimehq#2759

This commit...

1. sorts main header keys according to sublimehq#2430
2. adds or update `first_line_match` patterns to all appropriate syntax
   definitions in order to support emacs mode tags.

   Examples:

   // -*-c-*-
   // -*- c -*-
   // -*- mode: c -*-
   // -*- mode: c++; -*-

* [ActionScript] Fix first line pattern

* [ASP] Fix first line pattern

Moves `-*- asp -*-` to HTML (ASP).sublime-syntax

* [JSP] Add missing first line pattern

* [Java] Revert first line pattern

JSP is html like syntax and probably doesn't need or never sees such
mode comment.

* [ASP] Revert first line pattern

HTML (ASP) won't probably see any such comment, thus removing it.

* [All] Allow anything in front of emacs mode tag comments

Sync with PR sublimehq#2862

* [Haskell] Add shebang to first_line_match

* [Lua] Add shebang to first_line_match

* [ShellScript] Add DASH shebang

* [PHP] Add minor version support in shebang

Syncs modification from sublimehq#2915 to add support for
php executables such as

    php
    php7
    php71
    php7.1
    php7.1.3

to `first_line_match`'s shebang/editorconfig pattern.

* [Batch File] Add "@echo on" to first_line_match
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
T: enhancement Improvement of existing language features
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

[Common] Add or update emacs mode patterns deathaxe/sublime-packages
2 participants
@Grazfather @deathaxe