Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[JavaScript] Added new regexp features #1416

Closed
wants to merge 12 commits into from

Conversation

Thom1729
Copy link
Collaborator

@Thom1729 Thom1729 commented Feb 9, 2018

On top of #1415.

Adds support for:

  • Lookbehind assertions.
  • Unicode property escapes.
  • Named capture groups.
  • The dotAll (s) flag.

Also adds more detail to some existing constructs and fixes a couple of bugs.

@Thom1729
Copy link
Collaborator Author

Working on the conflict...

@wbond
Copy link
Member

wbond commented Feb 12, 2018

I was just doing that now since I squashed the previous PR 🙂

@Thom1729
Copy link
Collaborator Author

Ah, OK.

@wbond
Copy link
Member

wbond commented Feb 12, 2018

I ended up rebasing these on top of master and pushing directly there, just for a cleaner history. Thanks!

@wbond wbond closed this Feb 12, 2018
@Thom1729 Thom1729 deleted the javascript-improved-regexps branch February 12, 2018 16:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants