[JavaScript] Fix extended anonymous class declarations #1581
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Fixes sublimehq#1576 # Issue The `extend` keyword is matched as class name rather than keyword if directly following the `class` keyword in anonymous class definitions breaking the highlighting of the whole class body. # Solution Pop off from `class-name` context, if `extend` was found.
Thom1729
reviewed
May 16, 2018
JavaScript/JavaScript.sublime-syntax
Outdated
| @@ -1149,6 +1149,8 @@ contexts: | |||
| - include: expression-begin | |||
|
|
|||
| class-name: | |||
| - match: (?=\bextends\b) | |||
There was a problem hiding this comment.
In accordance with the new identifier parsing, this should be (?=extends{{identifier_break}}). Otherwise, it will fail on class extends$ {}.
|
My bad. Thanks for fixing it. |
This was referenced May 20, 2018
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #1576
Issue
The
extendkeyword is matched as class name rather than keyword if directly following theclasskeyword in anonymous class definitions breaking the highlighting of the whole class body.Solution
Pop off from
class-namecontext, ifextendwas found.