Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[JavaScript] Fixed bug with tagged template literals. #1612

Merged
merged 1 commit into from
Jun 18, 2018
Merged

[JavaScript] Fixed bug with tagged template literals. #1612

merged 1 commit into from
Jun 18, 2018

Conversation

Thom1729
Copy link
Collaborator

Tagged template literals were handled specially when the tag was an identifier, but the general case was broken (it caused the expression to end early). The general case has been fixed and the special case eliminated.

    1``
    /a/;
//  ^^^ - string
//  ^ keyword.operator.arithmetic
//    ^ keyword.operator.arithmetic

Part of #1600.

@user-982634 user-982634 mentioned this pull request May 24, 2018
Closed
@wbond wbond merged commit 3fea903 into sublimehq:master Jun 18, 2018
@Thom1729 Thom1729 deleted the javascript-fix-tagged-template-literals branch June 18, 2018 18:09
charlievieth pushed a commit to charlievieth/Packages that referenced this pull request Jul 25, 2018
[JavaScript] Fixed bug with tagged template literals. (sublimehq#1612)
3e6ee46
deathaxe pushed a commit to deathaxe/sublime-packages that referenced this pull request Jun 9, 2019
@wbond
[JavaScript] Fixed bug with tagged template literals. (sublimehq#1612)
e198562
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@Thom1729 @wbond