[JavaScript] Eliminate goto, add break/continue labels. #1613
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
keith-hall
approved these changes
Jun 16, 2018
djspiewak
approved these changes
Jun 18, 2018
charlievieth
pushed a commit
to charlievieth/Packages
that referenced
this pull request
Jul 25, 2018
deathaxe
pushed a commit
to deathaxe/sublime-packages
that referenced
this pull request
Jun 9, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
gotohas no meaning in JavaScript, but it was erroneously marked as a keyword.breakandcontinuetake optional labels. The syntax did not handle this, leading to bugs in corner cases.continuehad no tests at all.Part of #1600.