Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Perl] Fix regexp patterns at line start with tabs #1948

Merged
merged 2 commits into from
Jul 29, 2019

Conversation

deathaxe
Copy link
Collaborator

@deathaxe deathaxe commented Apr 28, 2019

This commit fixes an issue with regexp patterns not being detected, if tabs are used for indention.

Example:

$var =~
/pattern/;

The /pattern/ is now detected as such, even if the line starts with tabs.

Note: Can't add a test as PackageDev complains about tabs being used as indention.

This commit fixes an issue with regexp patterns not being detected, if
tabs are used for indention.

Example:

  $var =~
  /pattern/;

The `/pattern/` is now detected as such, even if the line starts with
tabs.

Note:

Can't add a test as PackageDev complains about tabs being used as indention.
@FichteFoll
Copy link
Collaborator

PackageDev should only complain when the setting to use tabs is active for a view and it also shouldn't prevent you from adding one after the popup has surfaced once. If switching to use tabs for indentation, adding a tab and then switching back does not work with PackageDev, please add your use case to SublimeText/PackageDev#177.

@wbond wbond merged commit 9350d2c into sublimehq:master Jul 29, 2019
@wbond
Copy link
Member

wbond commented Jul 29, 2019

Thanks!

@deathaxe deathaxe deleted the pr/perl-fix-patterns-after-tabs branch July 30, 2019 05:44
mitranim pushed a commit to mitranim/Packages that referenced this pull request Mar 25, 2022
* [Perl] Fix regexp patterns at line start with tabs

This commit fixes an issue with regexp patterns not being detected, if
tabs are used for indention.

Example:

  $var =~
  /pattern/;

The `/pattern/` is now detected as such, even if the line starts with
tabs.

Note:

Can't add a test as PackageDev complains about tabs being used as indention.

* [Perl] add test case
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants