Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[JavaScript] Scope builtin errors as support.class.builtin. #1982

Merged
merged 1 commit into from
Jul 29, 2019
Merged

[JavaScript] Scope builtin errors as support.class.builtin. #1982

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion JavaScript/JavaScript.sublime-syntax
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2053,7 +2053,7 @@ contexts:
scope: support.class.builtin.js
pop: true
- match: (?:Eval|Range|Reference|Syntax|Type|URI)?Error{{identifier_break}}
scope: support.class.error.js
scope: support.class.builtin.js
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Would it make sense to merge the pattern with the former one then?

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It would be compiled the same either way, so it shouldn't really matter.

pop: true

- match: (?:eval|isFinite|isNaN|parseFloat|parseInt|decodeURI|decodeURIComponent|encodeURI|encodeURIComponent){{identifier_break}}
Expand Down
16 changes: 8 additions & 8 deletions JavaScript/tests/syntax_test_js_support_builtin.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -13,7 +13,7 @@
// ^^^^^ support.function

new Error();
// ^^^^^ support.class.error
// ^^^^^ support.class.builtin

Array;
// ^^^^^ support.class.builtin
Expand Down Expand Up @@ -75,19 +75,19 @@
// ^^^^^^^ support.class.builtin

Error;
// ^^^^^ support.class.error
// ^^^^^ support.class.builtin
EvalError;
// ^^^^^^^^^ support.class.error
// ^^^^^^^^^ support.class.builtin
RangeError;
// ^^^^^^^^^^ support.class.error
// ^^^^^^^^^^ support.class.builtin
ReferenceError;
// ^^^^^^^^^^^^^^ support.class.error
// ^^^^^^^^^^^^^^ support.class.builtin
SyntaxError;
// ^^^^^^^^^^^ support.class.error
// ^^^^^^^^^^^ support.class.builtin
TypeError;
// ^^^^^^^^^ support.class.error
// ^^^^^^^^^ support.class.builtin
URIError;
// ^^^^^^^^ support.class.error
// ^^^^^^^^ support.class.builtin

Atomics;
// ^^^^^^^ support.constant.builtin
Expand Down