Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[JavaScript] Scope builtin errors with builtin. #2010

Closed
wants to merge 1 commit into from
Closed

[JavaScript] Scope builtin errors with builtin. #2010

wants to merge 1 commit into from

Conversation

Thom1729
Copy link
Collaborator

Fix #1980.

@FichteFoll
Copy link
Collaborator

Why not go for support.class.builtin.error.js?

@Thom1729
Copy link
Collaborator Author

I thought about that, but I'm not sure that the extra error scope is really useful. If you think it is, I can certainly add it back.

@FichteFoll
Copy link
Collaborator

I mean, it wouldn't hurt. I could see use in it for coloring error/exception classes.

It's a consideration for #1842 as well. Which I'll hopefully get to structure into a concrete proposal eventually.

@Thom1729
Copy link
Collaborator Author

Apparently this PR is an exact duplicate of #1982.

@Thom1729 Thom1729 closed this Jul 29, 2019
@Thom1729 Thom1729 deleted the javascript-error-builtin-scopes branch July 29, 2019 20:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[JavaScript] Error classes should also have "builtin" scope
2 participants
@Thom1729 @FichteFoll