Fix rulers #182
Merged
Fix rulers #182
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
description should also be updated |
masterdigger
approved these changes
Feb 26, 2024
rchl
reviewed
Feb 26, 2024
| @@ -217,7 +217,7 @@ | |||
| "default": "auto" | |||
| }, | |||
| "rulers": { | |||
| "markdownDescription": "Columns in which to display vertical rulers.\n\nAs of ST 4133 column and style (see `ruler_style`) can be paired.\n\ne.g.: `\"rulers\": [[80, \"solid\"], [100, \"dotted\"]]`", | |||
| "markdownDescription": "Columns in which to display vertical rulers. Each entry may also be a\n\nlist of the column, the ruler style and optionally the ruler width, for\n\nexample: `[[80, \"solid\", 2], 78, [90, \"dotted\"]]`", | |||
There was a problem hiding this comment.
We shouldn't be including newlines in the middle of the sentence. We should let it wrap by itself.
rchl
approved these changes
Feb 26, 2024
rchl
reviewed
Feb 26, 2024
| @@ -217,7 +217,7 @@ | |||
| "default": "auto" | |||
| }, | |||
| "rulers": { | |||
| "markdownDescription": "Columns in which to display vertical rulers.\n\nAs of ST 4133 column and style (see `ruler_style`) can be paired.\n\ne.g.: `\"rulers\": [[80, \"solid\"], [100, \"dotted\"]]`", | |||
| "markdownDescription": "Columns in which to display vertical rulers. Each entry may also be a list of the column, the ruler style and optionally the ruler width, for example: `[[80, \"solid\", 2], 78, [90, \"dotted\"]]`", | |||
There was a problem hiding this comment.
Note that if we want to separate paragraphs with \n\n then that's fine. I just meant hard wrapping at random point in the sentence.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
closes #180