Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add new context keys of 4K builds to the keymap schema. #92

Merged
merged 2 commits into from
May 30, 2021

Conversation

UltraInstinct05
Copy link
Contributor

This PR adds newly added context keys of the 4K build series to the keymap schema.

Note: These aren't in the official documentation yet. There is an open issue for it sublimehq/sublime_text#4063

Notes:

  1. I haven't added is_javadoc because I don't know what it does as a context key. I have marked the description for it as a TODO in PackageDev.

  2. panel_type is a new one (not yet added to PackageDev), added in 4097. (Will do so in a future PR to it)

This commit adds newly added context keys of the 4K build series to the
keymap schema.
Copy link
Member

@rwols rwols left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm wondering where these context keys are described? I can't find them on docs.sublimetext.io nor on https://www.sublimetext.com/docs/key_bindings.html#context

EDIT: I guess the linked issue is enough proof :)

schemas/sublime-keymap.json Outdated Show resolved Hide resolved
schemas/sublime-keymap.json Outdated Show resolved Hide resolved
schemas/sublime-keymap.json Outdated Show resolved Hide resolved
schemas/sublime-keymap.json Outdated Show resolved Hide resolved
@UltraInstinct05
Copy link
Contributor Author

I'm wondering where these context keys are described? I can't find them on docs.sublimetext.io nor on https://www.sublimetext.com/docs/key_bindings.html#context

As I said, it's not yet in the official documentation. One has to go through the Default/Default ($platform).sublime-keymap to find these. As for the community docs, there is an open issue to add these sublimetext-io/docs.sublimetext.io#39

@rchl rchl merged commit 21076ed into sublimelsp:master May 30, 2021
@UltraInstinct05 UltraInstinct05 deleted the add_new_context_keys branch May 31, 2021 06:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants