-
Notifications
You must be signed in to change notification settings - Fork 186
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Rework diagnostics #1170
Rework diagnostics #1170
Conversation
- Put the storage in the SessionBuffer class. - Add delay setting. - Add extra delay setting when the completion widget is visible - Allow an empty string for the diagnostics style to suppress in-line diagnostics. - Don't print a debug statement when a view is not found. Resolves #852 Resolves #858 Resolves #1089 Resolves #1155
Maybe it's expected at this stage but just wanted to say that testing this with:
and it seems quite erratic in that the diagnostics don't show for newly typed text that contains errors. I have to reopen the file for them to show up. |
Kill it! |
Oh, it's seconds, not milliseconds... |
Yes. Perhaps that's too confusing? The other, existing "duration" settings are in milliseconds. |
Then following existing convention would be better. And have |
Because that's what all the other duration settings use as unit.
|
This solves the base_dir problem in a straightforward way. i.e. we can just call a method
// no diagnostics in the view. If there were previous diagnostics in the view, | ||
// then the delay setting here is ignored and diagnostics are updated | ||
// immediately. | ||
"diagnostics_delay_ms": 0, |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think that this should be set to some decent value by default. Unless you feel that it's not finished or something (I haven't had a chance to try it out properly yet).
diagnostics.
Resolves #852
Resolves #858
Resolves #1089
Resolves #1155
Resolves #1130
This is still a WIP.