Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Introduce the storage_path #1372

Merged
merged 4 commits into from
Oct 18, 2020
Merged

Introduce the storage_path #1372

merged 4 commits into from
Oct 18, 2020

Conversation

rwols
Copy link
Member

@rwols rwols commented Oct 11, 2020

  • New classmethod for AbstractPlugin: storage_path().
  • Extra template string for expansion: ${storage_path} for use in .sublime-settings commands.

@rwols rwols assigned rchl and unassigned rchl Oct 11, 2020
@rwols rwols requested a review from rchl October 11, 2020 14:56
plugin/core/sessions.py Outdated Show resolved Hide resolved
plugin/core/sessions.py Show resolved Hide resolved
@rchl
Copy link
Member

rchl commented Oct 11, 2020

  • Extra template string for expansion: ${storage_path} for use in .sublime-settings commands.

For npm-based packages, it won't really work, if we want to include a dynamically generated node version in the path.

@rwols rwols merged commit 261264c into st4000-exploration Oct 18, 2020
@rwols rwols deleted the feat/storage-path branch October 18, 2020 18:43
@rwols
Copy link
Member Author

rwols commented Oct 18, 2020

It's time for a release I think :)

rchl added a commit that referenced this pull request Nov 6, 2020
rchl added a commit that referenced this pull request Nov 7, 2020
rchl added a commit that referenced this pull request Nov 7, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants