Skip to content

Always show the actions at the bottom of the hover popup #1517

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 3 commits into from
Dec 8, 2020
Merged

Always show the actions at the bottom of the hover popup #1517

merged 3 commits into from
Dec 8, 2020

Conversation

rwols
Copy link
Member

@rwols rwols commented Dec 7, 2020

I have a feeling some users miss out on these useful links. It doesn't hurt to
always show these links.

@rwols
Always show the actions at the bottom of the hover popup
5bd799e 
I have a feeling some users miss out on these useful links. It doesn't hurt to
always show these links.
@jwortmann
Copy link
Member

Why not just set the default setting to true then? There have been requests in the past to hide these links and I made a PR to introduce this setting some time ago. I'm one of the users who don't like to show these links for each small hover popup, and I remember that they didn't even work half of the time. I mostly use the hover popups to see descriptions and arguments of built-in functions, and I don't need a "Goto definition" or "Code actions" link in that case.

@rwols rwols merged commit bc59e53 into st4000-exploration Dec 8, 2020
@rwols rwols deleted the feat/always-show-actions branch December 8, 2020 20:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@rchl rchl rchl approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@rwols @jwortmann @rchl