Refine diagnostics presentation #1710
Conversation
If the diagnostic spans one line: - Draw errors and warnings as squigglies - Draw infos and hints as stippled If the diagnostic spans more than one line: always draw as a box. The diagnostics_highlight_style setting is removed, as these provide good defaults.
|
Let see where this goes. 👏 BTW, just noticed one problem, I get no underline if I set |
|
Will have a proper look tomorrow but after quick check noticed that warnings are drawn over errors whereas previously it was the other way around. The most severe issue should be surfaced, I'd think. Before: After: (Also noticed that gutter icon severity that is drawn is the opposite of the region severity. But that's not new and potentially unavoidable) |
|
Should that logic also apply to symbol highlight?
|
|
|
see 9cff9d3 |
This behavior also occurs on |
Related: #1710 Remove the "squiggly", "dotted" and "box" options for single-line highlights. "fill" and "underline" are possible. When set to "fill", "fill" is used for multi-line as well.
|
The "fill" trick for unnecessary and deprecated tags is also still working
Anybody against merging this? |
Co-authored-by: Rafał Chłodnicki <rchl2k@gmail.com>
If the diagnostic spans one line:
If the diagnostic spans more than one line: always draw as a box.
The diagnostics_highlight_style setting is removed, as these provide good
defaults.
Resolves #1547
Infos and hints as stippled:
Warnings and errors as squigglies:
If more than one line: always a box
cc @deathaxe, @kornelski