Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Support restart specific server #1733

Merged
merged 13 commits into from
Jun 15, 2021
Merged

Support restart specific server #1733

merged 13 commits into from
Jun 15, 2021

Conversation

husanjun
Copy link
Contributor

@husanjun husanjun commented Jun 9, 2021 •
edited
Loading

The from #1023

image

  1. If there was only one server it would be the same as before
  2. If there are more than one server, the server options are listed, and there are options to restart all of them
  3. Compatible with command line running and support running single server parameters

@husanjun husanjun closed this Jun 11, 2021
@husanjun husanjun deleted the restart-specific branch June 11, 2021 01:36
@rchl
Copy link
Member

rchl commented Jun 11, 2021 •
edited
Loading

Did the fix not work as expected or what's the reason for closing?

I think it's a welcome change but a bit tricky to do, the last time I've looked at it, so I wanted to find proper time to review it.

@husanjun husanjun restored the restart-specific branch June 11, 2021 07:19
@husanjun
Copy link
Contributor Author

Ah, I thought no one would be interested, well I'll recreate it and attach a screenshot

@husanjun husanjun reopened this Jun 11, 2021
rwols
rwols reviewed Jun 11, 2021
View reviewed changes
plugin/core/registry.py Outdated Show resolved Hide resolved
rchl
rchl reviewed Jun 11, 2021
View reviewed changes
plugin/core/registry.py Outdated Show resolved Hide resolved
rchl
rchl reviewed Jun 11, 2021
View reviewed changes
plugin/core/registry.py Outdated Show resolved Hide resolved
rchl
rchl reviewed Jun 11, 2021
View reviewed changes
plugin/core/registry.py Outdated Show resolved Hide resolved
rwols
rwols requested changes Jun 12, 2021
View reviewed changes
Default.sublime-commands Outdated Show resolved Hide resolved
rchl
rchl reviewed Jun 15, 2021
View reviewed changes
plugin/core/registry.py Outdated Show resolved Hide resolved
rchl
rchl reviewed Jun 15, 2021
View reviewed changes
plugin/core/registry.py Outdated Show resolved Hide resolved
@rwols rwols merged commit 93dc0d9 into sublimelsp:main Jun 15, 2021
@rwols
Copy link
Member

rwols commented Jun 15, 2021

Thanks, @husanjun

@rchl rchl mentioned this pull request Jun 15, 2021
Closed
@husanjun husanjun deleted the restart-specific branch June 17, 2021 08:14
litezzzout pushed a commit to litezzzout/LSP that referenced this pull request Jul 2, 2021
@husanjun
You can restart a specific server (sublimelsp#1733)
15e2166
@predragnikolic predragnikolic mentioned this pull request Aug 20, 2022
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@rwols rwols rwols requested changes

@rchl rchl rchl approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@husanjun @rchl @rwols