Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add back stippled option for document highlights #1748

Merged
merged 2 commits into from
Jun 13, 2021

Conversation

jwortmann
Copy link
Member

Because it is requested in #1712 by multiple users and there is already the setting for it, so I think it doesn't hurt to keep this option.

@thewchan
Copy link

Would other options like box it filled also be available as well?

@agnivade
Copy link

Thanks @jwortmann !

@jwortmann
Copy link
Member Author

Would other options like box it filled also be available as well?

You mean use the box style instead of background color for multiline regions, if the setting is set to "fill"?
The box style was introduced because it doesn't look well if the underline style is applied to big parts of a file (which only certain servers do). But I think that is no problem for the "fill" style:

fill

So another option for this is currently not supported, and I don't think it is necessary. Do you think it would be useful?

@thewchan
Copy link

This might be a weird me thing but I mostly stay away for the underline squiggles I possible because I basically reserve that or spell check...

@rwols rwols merged commit f5952e6 into sublimelsp:main Jun 13, 2021
@jwortmann jwortmann deleted the stippled-highlights branch June 13, 2021 20:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants