Generalize implementation of the transport #1847
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Extracted the JSON RPC-specific handling into a separate processor and used composition concept to pass and use it within the transport. That should allow re-using the transport implementation in the file watcher to implement a transport that uses plain lines of text rather than JSON RPC. Not using abstract classes anymore as that is not compatible with generic types.
rchl
commented
Sep 14, 2021
|
I probably want to rewrite this part of the code once we can use py38. How would that work when other packages use this code? |
The LSP-file-watcher-chokidar is tightly tied to LSP so I imagine those would have to be updated at the same time. |
rchl
commented
Sep 15, 2021
Comment on lines
+65
to
+70
| headers = http.client.parse_headers(reader) # type: ignore | ||
| try: | ||
| body = reader.read(int(headers.get("Content-Length"))) | ||
| except TypeError: | ||
| # Expected error on process stopping. Stop the read loop. | ||
| raise StopLoopError() |
There was a problem hiding this comment.
Changed so that explicit action is used to stop the read loop instead of relying on TypeError doing it.
We could maybe just raise StopLoopError() earlier by checking if headers.get("Content-Length") is None.
rwols
approved these changes
Sep 18, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Extracted the JSON RPC-specific handling into a separate processor
and used composition concept to pass and use it within the transport.
That should allow re-using the transport implementation in the file
watcher to implement a transport that uses plain lines of text rather
than JSON RPC.
Not using abstract classes anymore as that is not compatible with
generic types.