Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Don't allow old nested dict style keys anymore #1865

Merged
merged 3 commits into from
Oct 3, 2021
Merged

Conversation

rwols
Copy link
Member

@rwols rwols commented Oct 2, 2021

Fixes #1858

@rchl
Copy link
Member

rchl commented Oct 2, 2021

Have to be more careful when using update() now.

For example this is no longer entirely correct https://github.com/sublimelsp/LSP-vue/blob/d831ccd89b476f76b42d52a77bc1b8693dc85781/plugin.py#L24-L30
It will still work fine because it just so happens that the vetur.format.options doesn't contain any other keys than those that are updated but it's not really correct anymore.

Copy link
Member

@rchl rchl left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice and clean solution. Thought the problem is more difficult to solve.

rchl added a commit to sublimelsp/LSP-vue that referenced this pull request Oct 3, 2021
With sublimelsp/LSP#1865 in place, the updated
format is more correct (even though in this particular case either works
because `vetur.format.options` doesn't contain more options besides
those two).
@rwols
Copy link
Member Author

rwols commented Oct 3, 2021

Yeah, it took me quite a while to debug this.

@rwols rwols merged commit cad734c into main Oct 3, 2021
@rwols rwols deleted the fix/path-expand-keys branch October 3, 2021 17:55
rchl added a commit that referenced this pull request Oct 5, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Unwanted splitting on dot of the setting keys
2 participants