Pass force_group to LocationPicker #2134
Conversation
|
Judging from the diff here, the argument is still not passed from the "Goto ..." commands. So I guess at the current state it wouldn't solve the linked issue, and still just use the default value |
|
I admit I haven't bothered to test the original issue but I've assumed that this is fixing the case when somewhere has defined a custom command that passes "force_group: false". Is that not the case? |
|
I see now. Forgot to change the place that you've actually indicated is the issue. That said, still haven't tested as pyright doesn't trigger this code path and I didn't bother to find out how to trigger it otherwise. |
|
Looks better now @jwortmann ? |
|
Yes, should be fine to merge now. It was obvious to me that you had just forgotten to adjust the other place in the code. Maybe I should have expressed that more clearly ;-) |
* main: (30 commits) Make Document Symbols behavior more consistent with built-in Goto Symbol (#2166) docs: fsautocomplete config - remove redundant argument (#2165) Allow missing window/workDoneProgress/create request from the server (#2159) Use "plaintext" language ID for plain text files (#2164) Improve type annotations (#2162) Don't use "escapeall" extension when formatting with mdpopups (#2163) Cut 1.21.0 Fix inlay hint parts wrapping into multiple lines (#2153) Ensure commands triggered from minihtml run on correct view (#2154) Add "Source Action" entry to the "Edit" main menu (#2149) Add "Refactor" entry to the "Edit" main menu (#2141) fix completion documentation being parsed as markdown twice (#2146) when going to definition scroll to start of the region, not end (#2147) Auto-restart on server crashing, up to 5 times (#2145) improve performance of completion & signature request on typing (#2148) fix code lenses not updating after Undo (#2139) docs: fix mixed indentation in language servers configuration add missing Goto commands to Command Palette (#2140) docs: add missing keyboard shortcuts (#2143) Pass force_group to LocationPicker (#2134) ...
Addressing issue mentioned in #1994 (comment)