better grouping of default settings #2206
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
predragnikolic
approved these changes
Feb 24, 2023
rwols
reviewed
Feb 24, 2023
| "gopls" | ||
| ], | ||
| "selector": "source.go", | ||
| }, |
There was a problem hiding this comment.
I used to announce this removal in a previous release message. Make sure to announce this in the current release message. Now that I’m writing this, I’m not sure if it’s a good idea to remove this without an announcement message.
There was a problem hiding this comment.
Because it may break current user’s workflow.
There was a problem hiding this comment.
Added changelog listing breaking changes.
It will be updated before release to list all other changes.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Did a bit of grouping of options to make default settings a bit more organized.
Also removed default configs for rust-analyzer, clangd and gopls since we have dedicated packages for those.
Improvement suggestions welcome.