notify opened files immediately if there are pending diagnostics #2211
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rchl
commented
Feb 26, 2023
plugin/session_view.py
Outdated
Comment on lines
54
to
56
| session_buffer = SessionBuffer(self, buffer_id, uri) | ||
| self._session_buffers[key] = session_buffer | ||
| self._session.register_session_buffer_async(session_buffer) |
There was a problem hiding this comment.
Previously SessionBuffer registered itself in Session with:
self._session.register_session_buffer_async(self)This caused crash as Session.register_session_buffer_async was called before self._session_buffers[key] = session_buffer and would crash depending on what we would want to do with SessionBuffer.
I think it makes more sense for SessionView to register SessionBuffer with Session as it is also responsible for creating SB.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Diagnostics are stored in
Sessionand there might exist diagnostics for not-yet-opened files so notify Session Buffers immediately about those when creating new buffers.This fixes somewhat obscure bug for servers that don't implement
didOpenbut also makes diagnostics show more quickly after opening files for other servers (in case diagnostics were already reported for those files).Fixes #2200