fix "Error rewriting command" warning triggered on startup #2277
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rchl
changed the title
jwortmann
approved these changes
May 30, 2023
|
Thanks for checking. The warning is new addition in latest dev builds but the issue was there even before the warning was introduced. The issue being that triggering a command directly from Also related issue in ST about this warning being misleading: sublimehq/sublime_text#5978 |
rchl
added a commit
that referenced
this pull request
May 30, 2023
* main: fix "Error rewriting command" warning triggered on startup (#2277) Take font style of sighelp active parameter from color scheme (#2279) Add argument "include_declaration" to "lsp_symbol_references" (#2275) fix crash on checking excluded folders with missing project data (#2276) Fix tagged diagnostics flickering on document changes (#2274) Cut 1.24.0 use class for diagnostic info instead of hardcoding color (#2257) Fix package storage path in a docstring description (#2256) Use regular font style in sighelp popup if already highlighted by color scheme (#2259) update note about custom color scheme rule used for diagnostics (#2254)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes
Error rewriting command lsp_recheck_sessions. Encountered infinite loopwarning on startup.The warning is a bit misleading. It triggers not due to an infinite loop but due to triggering a window command directly from
plugin_loaded. Basically means that triggering this command on startup had no effect but that's fine because at that point there is no sessions yet so it wouldn't really do anything anyway.This PR removes the
LspRecheckSessionsCommandcommand in favor of a more explicit notification triggered from theWindowConfigManagerto theWindowManagerto let it know that sessions should be restarted (the approach with usingLspRecheckSessionsCommandwas just a hack around the fact thatWindowConfigManagerdid not have access toWindowManager).Also note that I've changed
WindowConfigManagerto not trigger sessions restart on__init__since it's unnecessary since there are no sessions yet. That's why most of theupdate()code was moved to_reload_configs()and called on init.