Only do a single pass on running code actions on save #2283
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
predrag-codetribe
approved these changes
Jun 4, 2023
There was a problem hiding this comment.
Tested ✅
I checked
"source.fixAll.eslint"- with the code from this PR, this will no longer happen Run code actions on save only once #2270- and
"source.organizeImports"(with LSP-typescript), I am able to undo as expected, (previously it was sometimes impossible to undo)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Previously we have been re-running Code Actions on Save if the document got modified by code action. This have in some cases resulted in a loop that would only terminate on timeout. Changed so that each server only has one chance to run code actions on save.
Fixes #2231
Fixes sublimelsp/LSP-typescript#202